drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.56k stars 480 forks source link

Move GifControlHeader.DisposalMethod to GifControlDescriptor #412

Open kwhopper opened 5 years ago

kwhopper commented 5 years ago

https://github.com/drewnoakes/metadata-extractor/blob/8352ce2bdfe559f0c2d28bd109e3a82af79abcbc/Source/com/drew/metadata/gif/GifControlDirectory.java#L119

With the enum toString structure, it doesn't appear possible to return the actual value when the 'INVALID' enum value is encountered. Maybe DisposalMethod description processing should be moved to GifControlDescriptor?

(These enum toString things seem convenient but are not very flexible.)

This was changed for .NET in drewnoakes/metadata-extractor-dotnet#181