drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.56k stars 480 forks source link

Can now extract Exif from HEIF images where 'meta' is not the first box #489

Closed normana10 closed 3 years ago

normana10 commented 4 years ago

I have not found any spec that says the 'meta' box has to be the first box in the file and we need the meta box to pick our handler.

When the meta box is the first box, we process like normal. If the meta box is not the first box, we scan through the entire file and set the handler when we do find the meta box. Then we reset the stream (if we can) and process it with that new handler.

So this WILL break if the meta box is not the first AND the stream is not resettable...

Associated images PR: https://github.com/drewnoakes/metadata-extractor-images/pull/37

Resolves #487

normana10 commented 4 years ago

@drewnoakes Not sure if you've gotten around to this, but it should be good to go

Let me know if you have any feedback

Thanks!

deckerst commented 3 years ago

This fix would be very helpful for my project. @drewnoakes how can we help to get this PR merged (and released) ?