search

drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.56k stars 480 forks source link

Can't get descripted Samsung makernote tags as SamsungType2MakernoteDirectory #505

Closed dohykim closed 3 years ago

dohykim commented 3 years ago

I have Samsung galaxy S8+ and read all meatadata from my photos I saw undescripted one that is 'Makernote : [98 values]'.

I read around and guess SamsungType2MakernoteDirectory type not detected. at ExifTiffHandler.java line 511 if (!"SAMSUNG".equals(cameraMake)) { return false; } I think it should be equalsIgnoreCase

image result : com.drew.metadata.exif.ExifSubIFDDirectory -- Exif SubIFD /// Makernote : [98 values]

and edit to uppercase image result: com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Maker Note Version : 1.00 com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Device Type : Cell Phone com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Unknown tag (0x000c) : 0 com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Unknown tag (0x0010) : 90/65689 com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Raw Data Byte Order : Little-endian (Intel) com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Raw Data CFA Pattern : Swap com.drew.metadata.exif.makernotes.SamsungType2MakernoteDirectory -- Samsung Makernote /// Face Detect : Off

dohykim commented 3 years ago

20170209_195138 add sample file that originally lowerCase maker

drewnoakes commented 3 years ago

@dohykim I agree, it does look like ignoreCase comparision would be better here. Would you like to make a pull request?

Also, are you happy to donate that sample image to the project for testing purposes?

dohykim commented 3 years ago

yes sure