search

drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.55k stars 479 forks source link

Add Schema.PHOTOSHOP_PROPERTIES #520

Closed cowwoc closed 3 years ago

cowwoc commented 3 years ago

Please add Schema.PHOTOSHOP_PROPERTIES = "http://ns.adobe.com/photoshop/1.0/" for extracting photoshop-specific XMP tags.

drewnoakes commented 3 years ago

Sounds reasonable. Can you submit a pull request?

cowwoc commented 3 years ago

@drewnoakes Does the above PR work for you?

drewnoakes commented 3 years ago

@cowwoc thanks for following up. That PR targets your fork of the project, not this one. That is, merging it would modify your fork, not this repo.

Can you create a new PR from the branch on your fork against this repo? This URL should do the job:

https://github.com/drewnoakes/metadata-extractor/compare/master...cowwoc:schema-photoshop

cowwoc commented 3 years ago

@drewnoakes Good catch. I've created two new PRs for your review. The second one can be found at https://github.com/drewnoakes/metadata-extractor/pull/523