search

drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.57k stars 481 forks source link

Nikon PictureControl directory extraction #634

Closed gtiwari333 closed 10 months ago

gtiwari333 commented 10 months ago

This PR ports the change that were made on C# repo to this Java repo. https://github.com/drewnoakes/metadata-extractor-dotnet/pull/341/files

gtiwari333 commented 10 months ago

@drewnoakes please review and merge/release this.

The image files that i used are from https://github.com/drewnoakes/metadata-extractor-images/wiki/ContentSummary. Let me know if there's an easier way to crop/resize those images to low resolution and preserve all the metadata.

gtiwari333 commented 10 months ago

I added the tests back with APP1 segment data created using ExtractJpegSegmentTool.

drewnoakes commented 10 months ago

Please remove all test data and unit tests and squash history. We use the regression test suite for this as it's more comprehensive, has better ergonomics, and allows comparison between Java and .NET implementations.

gtiwari333 commented 10 months ago

Will open new PR with squashed commits