search

drewnoakes / metadata-extractor

Extracts Exif, IPTC, XMP, ICC and other metadata from image, video and audio files
Apache License 2.0
2.53k stars 473 forks source link

Fixed wrong date/time when timezone is null #651

Closed StefanOltmann closed 5 months ago

StefanOltmann commented 5 months ago

The code should not default back to GMT timezone, but instead assume that the image was taken in the same timezone as the computer is in. That should be true for most images.

The PngMetadataReaderTest had a pattern to deal with this. I expanded this to the other failing unit tests.

Fixes #628.

StefanOltmann commented 5 months ago

@drewnoakes The tests don't run on this, because you recently changed the branch name from "master" to "main", but you also need to adjust this:

https://github.com/drewnoakes/metadata-extractor/blob/753cf1f514dff829af2782a60c81720ab161aa83/.github/workflows/maven.yml#L7-L10

PR for fix: https://github.com/drewnoakes/metadata-extractor/pull/652