search

drewnoakes / xmp-core-dotnet

.NET library for working with the Extensible Metadata Platform (XMP)
60 stars 22 forks source link

Add strong name signing in separate nuget package #25

Closed Tasteful closed 7 years ago

Tasteful commented 7 years ago

Alternative to the PR #24 that strong name signing all libraries. This PR creates a separate nuget-package that is strong name signed.

When running the Build.cmd all packages is created, test are run and artifacts are placed in the artifacts folder to upload directly to nuget.

drewnoakes commented 7 years ago

One difference here is that msbuild doesn't produce a symbols package, which dotnet pack did. I'm not sure it's a huge problem, but if you know a simple way to get symbols from msbuild too...

Tasteful commented 7 years ago

Do you want the pdb in the same package or in an symbol package?

drewnoakes commented 7 years ago

The current .nupkg is fine as is -- with DLL and XML.

What used to be produced was another .symbols.nupkg file with the same prefix, that contained DLL, XML, PDB and source code. This would be automatically uploaded by nuget push to Microsoft symbol server and could be downloaded by users in Visual Studio (and possibly other IDEs).

drewnoakes commented 7 years ago

Here's an example: XmpCore.2.0.1.symbols.nupkg.zip

drewnoakes commented 7 years ago

Pushed 5.1.3.0 to NuGet, including the strongly named variant.