Add a PCL project (Issue #4) and fix conversion issues

[kwhopper]

4:

• removed Serializable
• removed ICloneable
• Encoding.GetEncoding has no int overload; use string
• Encoding.GetString has no array overload; use array, index, count
• TimeZoneInfo.CreateCustomTimeZone doesn't exist; use TimeZoneInfo.Local
• Add and expose IXmpDateTime.Offset to override timezone
• string.Any replaced with string.ToCharArray().Any
• string.All replaced with string.ToCharArray().All
• replace HashTable() with Dictionary<string, PropertyOptions>()
• MemoryStream.GetBuffer not available. Use MemoryStream.ToArray()
• Stream.Close() not available. Remove
• replace ArrayList with List
• TimeZoneInfo.ConvertTime has no 3-input overload. Use 2-input

[drewnoakes]

Looks good, though I wonder if we can take the approach used in metadata-extractor-dotnet of having the XmpCore.Portable.csproj file in the same folder as the non-portable .csproj file, such that they both use the same source files. Any differences between these would then be hidden behind #if PORTABLE ... #endif or similar. Doing this avoids having two copies of each source file, meaning bug fixes in one version end up in both.

Merging this for now as this is valuable work. Would be good to consolidate the two folders and cut down on duplication.

[kwhopper]

Agreed. I haven't done that before, but can try if you want. You might be able to do it faster.

[drewnoakes]

It's a nice pattern I first encountered in the NetMQ project.

On 13 December 2015 at 00:42, kwhopper notifications@github.com wrote:

Agreed. I haven't done that before, but can try if you want. You might be able to do it faster.

— Reply to this email directly or view it on GitHub https://github.com/drewnoakes/xmp-core-dotnet/pull/7#issuecomment-164204946 .