[Bug] jakarta dependency but referencing javax for imports

CoryBarney commented 4 months ago

Been trying to update the version of postal on a project and noticed some dependency mismatches where the project is pulling in jakarta but importing javax.

Was wondering if it would be okay to update the imports to reference jakarta to future proof it for a bit?

drewr commented 4 months ago

Hey @CoryBarney! What deps conflicts are you getting?

CoryBarney commented 4 months ago

Morning Drew @drewr, Sorry about the vague ticket ill get more details later when I swing back around to fighting with this but essentially without:

    <dependency>
      <groupId>com.draines</groupId>
      <artifactId>postal</artifactId>
      <version>2.0.5</version>
    </dependency>

    <dependency>
      <groupId>javax.mail</groupId>
      <artifactId>javax.mail-api</artifactId>
      <version>1.6.2</version>
  </dependency>

I end up getting a compilation error at line 1 message.clj stating javax.mail is not present as the dependency in the postal build pulls in the new none javax version of the library that I believe is due to licensing called jakarata:

project.clj

  :dependencies [[commons-codec "1.9"]
                 [com.sun.mail/jakarta.mail "1.6.5"]]

which has a class path of jakarta. instead of what is referenced in the source code of javax.

Ill try to get a PR out but it should just be a matter of updating the imports though I am not sure of the side effects personally

drewr / postal

[Bug] jakarta dependency but referencing javax for imports #114