Closed charles-dyfis-net closed 9 years ago
Looks good, thanks. I wonder if we should just support all of the parameters by taking an optional array of strings?
https://javamail.java.net/nonav/docs/api/com/sun/mail/smtp/package-summary.html
Oh, mind updating the tests?
Thank you for your prompt review.
Please consider the most recent commit (1ea346b) a proposal available to be taken or left on your discretion as to whether it's a good idea -- b92cdb8 adds extra test cases to the original PR, and should be ready for merge without 1ea346b should you so choose.
By the way -- would you have a rough ETA on consideration so I can do release planning for my dependent code? If you don't intend to merge for a while, but do think the implementation looks plausible, I'll likely implement the current proposal as monkeypatch on my end. (The side benefit of this is that it means there'd be actual professional-QA-staff testing pre-merge, if you were inclined to go that route).
@charles-dyfis-net So sorry for the delay here. postal alerts got buried in my inbox this year and I haven't seen them surface until recently!
I've cut 1.11.4
with this change. Would you mind trying it out?
I'm trying to coordinate with my dev and QA teams (the codebase using postal internally is one I don't personally own), and will let you know when we've gotten some testing done and what the results look like.
We've successfully tested against the 1.11.4 release with our monkeypatches removed. Many thanks!
Great, thanks @charles-dyfis-net!
Two new
mail.smtp
properties are made accessible:localhost
sets the host name used in the EHLO command.localaddress
sets the address to bind to when generating the outbound connection (for multihomed hosts).