drewr / postal

Clojure email support
MIT License
587 stars 85 forks source link

Allow local address configuration for multihomed hosts #55

Closed charles-dyfis-net closed 9 years ago

charles-dyfis-net commented 9 years ago

Two new mail.smtp properties are made accessible:

drewr commented 9 years ago

Looks good, thanks. I wonder if we should just support all of the parameters by taking an optional array of strings?

https://javamail.java.net/nonav/docs/api/com/sun/mail/smtp/package-summary.html

drewr commented 9 years ago

Oh, mind updating the tests?

charles-dyfis-net commented 9 years ago

Thank you for your prompt review.

Please consider the most recent commit (1ea346b) a proposal available to be taken or left on your discretion as to whether it's a good idea -- b92cdb8 adds extra test cases to the original PR, and should be ready for merge without 1ea346b should you so choose.

charles-dyfis-net commented 9 years ago

By the way -- would you have a rough ETA on consideration so I can do release planning for my dependent code? If you don't intend to merge for a while, but do think the implementation looks plausible, I'll likely implement the current proposal as monkeypatch on my end. (The side benefit of this is that it means there'd be actual professional-QA-staff testing pre-merge, if you were inclined to go that route).

drewr commented 9 years ago

@charles-dyfis-net So sorry for the delay here. postal alerts got buried in my inbox this year and I haven't seen them surface until recently!

drewr commented 9 years ago

I've cut 1.11.4 with this change. Would you mind trying it out?

charles-dyfis-net commented 9 years ago

I'm trying to coordinate with my dev and QA teams (the codebase using postal internally is one I don't personally own), and will let you know when we've gotten some testing done and what the results look like.

charles-dyfis-net commented 9 years ago

We've successfully tested against the 1.11.4 release with our monkeypatches removed. Many thanks!

drewr commented 9 years ago

Great, thanks @charles-dyfis-net!