Closed charles-dyfis-net closed 8 years ago
@drewr, if you have a chance to weigh in on whether I've gone the right approach here with duplicating rather than inferring, I'd appreciate the feedback.
Thanks for catching that @charles-dyfis-net. Looks good to me.
Per (the docs)[https://javamail.java.net/nonav/docs/api/com/sun/mail/smtp/package-summary.html]:
At present, we always set only
mail.smtp
properties from keywords.Granted, we could try to determine the protocol from inspecting the properties passed, but always setting properties for both possibilities is the more robust approach, precluding any possibility of making the determination wrongly.