search

drewr / postal

Clojure email support
MIT License
586 stars 85 forks source link

Convert keywords to both mail.smtp. and mail.smtps. properties #71

Closed charles-dyfis-net closed 8 years ago

charles-dyfis-net commented 8 years ago

Per (the docs)[https://javamail.java.net/nonav/docs/api/com/sun/mail/smtp/package-summary.html]:

Note that if you're using the "smtps" protocol to access SMTP over SSL, all the properties would be named "mail.smtps.*".

At present, we always set only mail.smtp properties from keywords.

Granted, we could try to determine the protocol from inspecting the properties passed, but always setting properties for both possibilities is the more robust approach, precluding any possibility of making the determination wrongly.

charles-dyfis-net commented 8 years ago

@drewr, if you have a chance to weigh in on whether I've gone the right approach here with duplicating rather than inferring, I'd appreciate the feedback.

drewr commented 8 years ago

Thanks for catching that @charles-dyfis-net. Looks good to me.