drewtyler / TagproAuction

Code for Tagpro Auction site
MIT License
0 stars 8 forks source link

Make MBM count = 2, not 3 in teamdata.json #19

Closed drewtyler closed 9 years ago

MercuryRising commented 9 years ago

ghostboosters should have been able to bid for bowtie b.c. of keeper points colors for bids stay on for two people.

Don't know why this happens. We might want to check with a test case to ensure that it's still a problem.

Maybe make it so you can't click bid buttons you cannot afford enforce nominations

I switched the buttons so it only includes values you can afford (money+keeperpoints).

do setTimeout() when bid accepted, cancel the settimeout and make a new one

We need this. As the auction went on, it seemed like the time was getting less and less, some players were going onto two teams, and some were being picked immediately. Might be the time bug we saw last week.

It might be a good idea to include a 'reopen bidding' option, where the last player that was won gets properly removed, and the bidding reopened at the last value.

make a 3 second no-bid-zone after a bid is accepted

This is still a good idea I think.

pause and start it again, skips that persons nomination

I think this will always do it because that's the way the start button is set up (it calls next nominator). If we accidentally press it, we could always just loop through the nominators to get back where we messed up.

don't let people bid negative

Done.

when undid nomination, skipped people

I think this is good now.

force check the player you nominate is in the list

I'm not sure how important this actually is, but if you want to implement it you can. Make sure the admins can always nominate people (overrides in case of bugs).

make sure people already drafted cannot be re-nominated if(teamdata.find({name: player}).count() > 0) { // don't let them be nominated }

rate-limit messages

Kinda done - no more 0 length messages.

message times still wonky

Done - switched to livestamp style time.

make sure message text > 0 length

Done.

use settimeout on the last bid team color thing to ensure only one is set at a time

This isn't a problem anymore (it will always find the proper color).

Okay. So I think we desperately need the set timeout. I looked for a second, but Bull, you might want to implement this when you wake up tomorrow. We can do another exhaustive test before the draft to make sure everything is running well. I noticed some weird timing related bugs towards the end of the auction (that were not present at the beginning, oddly enough). No idea what they're about - but players would be instantly put on teams, one time a player was put on multiple teams. I think the timeout will help alleviate many of these problems, as well as double messages.

MercuryRising commented 9 years ago

Added the timeouts. They seem to be working fine. Can't really tell if they work all the way until we get a stress test.