search

drewwilson / AutoSuggest

jQuery AutoComplete Plugin
http://code.drewwilson.com/entry/autosuggest-jquery-plugin
86 stars 46 forks source link

Removing autosuggests & classes vs IDs #19

Closed jakubpawlowicz closed 3 years ago

jakubpawlowicz commented 12 years ago
soberstadt commented 12 years ago

@drewwilson has had good reason to ignore the other PRs, but this works and shouldn't be ignored.

knalli commented 12 years ago

Hi. What impact have theses changes? What is the benefit? I'm looking for any interesting stuff we could integrate in our new version at https://github.com/hlsolutions/jquery-autosuggest/.

jakubpawlowicz commented 12 years ago

Hi @knalli,

There are two benefits: 1) By using classes instead of IDs one can have more than one autosuggest on a page while not violating ID uniqueness. 2) By using improved close method one can has commas inside selected values, e.g. "Paris, France", "London, United Kingdom" and not worry about these being accidentally removed.

Impact of #1 is quite heavy as it could tear apart 3rd party code depending on IDs. #2 seems to be pretty safe.

knalli commented 12 years ago

Oh, I thought this would be something new. It seems that these both things are already part of the other forks. Perhaps you give us a try?

jakubpawlowicz commented 12 years ago

Unfortunately I no longer work on a project this patch originated from so I can't give the new version a try. Feel free to close this pull request if you believe both bugs are covered in the new version.

knalli commented 12 years ago

Well, this isn't my project. I'd made a fork of a fork of this (well...) because of some issues including the one you already mentioned.

As I said, I'm only looking for interesting features which weren't integrated already.

jakubpawlowicz commented 12 years ago

I see. Feel free to include what you need or like!

jakubpawlowicz commented 3 years ago

It's been so long for this PR so let's close it.