add npm package.json - Githubissues

drewwilson / TipTip

Intelligent ToolTip jQuery Plugin

http://code.drewwilson.com/entry/tiptip-jquery-plugin

124 stars 70 forks source link

add npm package.json #23

Open glensc opened 8 years ago

glensc commented 8 years ago

used by cdnjs https://github.com/cdnjs/cdnjs/pull/6418 but could be useful otherwise as well.

ps: once merged, please tag v1.3 in github!

danimesq commented 8 years ago

Hi, @glensc I've forked TipTip to maintain it and use in all web projects of my community. Please clone your pull request to: https://github.com/Software-js/TipTip Thanks!

glensc commented 8 years ago

you can do all that yourself!

1. you can merge this from commandline:

git remote add glensc https://github.com/glensc/jquery.tiptip.git
git fetch glensc
git merge glensc/package.json --no-ff

1. or create pull request yourself:
  - https://github.com/glensc/jquery.tiptip/tree/package.json
  - New pull request
  - adjust Base fork
  - ...etc

glensc commented 8 years ago

and instead of forking, did you try to reach @drewwilson and ask to transfer ownership to you?

danimesq commented 8 years ago

I prefer the first option of the first reply. Good idea, I wasn't thinked about. About second reply, I prefer forking instead of get ownership of a thing I isn't created, then I prefer forking. Thanks to contributions and ideas!

danimesq commented 8 years ago

I'm thinking now, get ownership is an good idea for pull requests come direct to me for approve. I will contribute more with and think about. Thanks ;)

"ps: once merged, please tag v1.3 in github!" Can be more clear about how do this?

glensc commented 8 years ago

seems you're new to this, it's not really about "preference" or "not preferring" thing.

well. the original author does not go anywhere, he's still in copyright blocks and readme. please talk to him, then don't need to transfer tickets, have several forks around and nobody knows which one is the right one!

also, there's second option too, he can add you as collabrator (multiple developers) so the url stays as is. altho if original author is absolutely not interested anymore of this product, the transfer is better option, he'll get free of the burden as well :)

and if you go with "transfer" option, then the old urls keep working (github will redirect) and internet will not be broken because old links used elsewhere will keep working, including git remote urls!

as for github release, it's just git tag which you push (google here!)

danimesq commented 6 years ago

@glensc Merged in: https://github.com/ScreensOS/TipTip/pull/3.