drexjj / sbitx

An improved version of the sBITX application and operating system for the HF Signals sBitx hardware.
http://w9jes.com/
20 stars 7 forks source link

Patch v4.02 DE LPF Relay and Volume Fix #92

Closed drexjj closed 1 month ago

drexjj commented 1 month ago

These fixes are for the DE hardware only:

Fixes the LPF filter switching in CW modes Fixes the "no audio" issue after a PTT or key event.

Mashintime commented 1 month ago

Unable to test, but looks sane to me.

MikeJohnshoy commented 1 month ago

I see the changes for correctly calling either tr_switch_de or tr_switch_v2 are planned for v4.02. But I decided to run a simple test anyway on v4.01 which I just downloaded.

In 4.01 sbitx.c I added a printf("entered tr_switch_de to transmit"); and a printf("entered tr_switch_de to receive)" in the first and second parts of tr_switch_de. I put the same sort of statments in tr_switch_v2. As I expected, on my DE the software still calls tr_switch_v2 for all switches. I never saw it enter tr_switch_de. And I can hear the LPF relays with every key press.

So, I think we really don't have to worry about V2 and V3 users - I don't think they will see any change! The difference is, the tr_switch_de code has been "dead" or not called for versions I suspect going back to 32 bit days. I know I have been manually modding the source for each version for many versions ...