search

drexlerd / Loki

GNU General Public License v3.0
4 stars 3 forks source link

Handling of duplicate entities in PDDL files #2

Closed drexlerd closed 10 months ago

drexlerd commented 11 months ago

Option 1: throw an error Option 2: simply filter them out using sets

jendrikseipp commented 11 months ago

Modeling bugs should be presented loudly to users. This sounds like a modeling bug so I'm in favor of aborting with an error.

drexlerd commented 11 months ago

An example error report for multiple definitions of a constant ;)

terminate called after throwing an instance of 'loki::MultiDefinitionConstantError'
  what():  The constant with name "roomb" has already been defined.
In file benchmarks/gripper/domain.pddl, line 3:

   (:constants rooma roomb roomb)
                           ~~~~~ <<-- Here