search

dreyescat / bootstrap-rating

Bootstrap Rating is a jQuery plugin that creates a rating control that uses Bootstrap glyphicons for rating symbols.
http://dreyescat.github.io/bootstrap-rating/
MIT License
192 stars 78 forks source link

Readonly Problem #6

Closed RoesWibowo closed 9 years ago

RoesWibowo commented 9 years ago

There's something wrong with my readonly rating. I have 5 stars rating with value 5, but rating icon is empty. For rating below 5, it works fine.

dreyescat commented 9 years ago

Thanks @ReyzWB for the catch! It should be fixed now.

It was a problem regarding the old way to define the ranges. In version 0.x the upper index wasn't included, so the default range was [0..5), and hence 5 was not included [0, 1, 2, 3, 4]. Due to the addition of fractional symbols, I decided it was better to change ranges to (0..5], and hence having [1, 2, 3, 4, 5]. But, as you found out, not everything was properly upgraded :).