search

drf-forms / drf-schema-adapter

Making using Django with frontend libraries and frameworks DRYer
http://drf-schema-adapter.readthedocs.io/en/latest/
MIT License
157 stars 40 forks source link

Allow __all__ keyword for field definition with non factory serializer #39

Closed Ptosiek closed 6 years ago

Ptosiek commented 6 years ago

Couldn't find any example with wizard usage, but the changes shouldn't break it. I minimized the changes there but I think the usage of serializer class vs instance should be normalized.

nanuxbe commented 6 years ago

I guess you have your answer :-) When the library was first developed (back with DRF 3.2) using serializer instance was not an option.

I think changing from using serializer class to serializer instance is probably a good option though but this means that the documentation has to be updated (compatibility matrix in both the README and the main documentation) as well as the test setups (travis and tox)

Regarding wizards, I've just added tests to have basic coverage.

nanuxbe commented 6 years ago

Merged as part of https://github.com/drf-forms/drf-schema-adapter/commit/8c7beb14f2ed32fe79235a4f3739df0b8c28e06c

Thanks :-)