drfaustusfade / ngm-reportDesk

The workdesk for ReportHub
0 stars 1 forks source link

CVA updates #41

Open drfaustusfade opened 3 years ago

drfaustusfade commented 3 years ago

priority: not urgent

Cash Voucher Assistance: cash or vouchers modality

1. renaming mpc_delivery_type_id => modality_id mpc_mechanism_type_id => delivery_mechanism_id mpc_transfer_category_id => transfer_category_id mpc_grant_type_id => grant_type_id mpc_package_type_id => package_type_id mpc_transfer_type_id => transfer_type_id

note: activities config, forms, models, database records

2. units unit_type_id should be filtered, for example for in-kind there should not be currency units

modality_id cash can have currency units vouchers can have currency, commodity, service units depending on delivery_mechanism_id in-kind can have commodity units service can have service type units

unit_category_id: currency, commodity, service

possible implementations unit_type_id array has additional unit_category_id: currency | commodity | service

on changing Implementation modality or Transfer Mechanism if modality_id/delivery_mechanism_id contains a unit_category_id array/object [ currency , commodity ] { currency , commodity } updateUnitsFilter filter units array or custom filter on units if modality_id/delivery_mechanism_id contains an array/object

3. there should be a possibility to not show modality and automatically set it if one to one relation of activity to modality for example, if adding show_modality attribute on activities, if it is set to 0 but modality_id is present then to set modality and other delivery_mechanism_id, transfer_type_id, mpc_package_type_id if present or alternatively if hidden: 0 on modality_id but former is easier for end user

4. the same for transfer_category_id, grant_type_id ,if adding display_transfer_details attribute on activities

5. to add input communities if activities communities attribute is true total amount calculation is the same as for households

6.

transfer_type_value => transfers on model

7. total amount transferred optional/could be omitted that might have more sense to display if mpc_transfer_type_id and display_total_amount

fakhrihawari commented 3 years ago

i starting from 1( renaming) , Can you explain from 2 to 7?

fakhrihawari commented 3 years ago

https://github.com/fakhrihawari/ngm-reportHub/tree/CVA-update file activities config with renaming https://docs.google.com/spreadsheets/d/1CwwOKxwPxovtPWOLnCklObBgIlXtNSXAZ45PzOr9uGM/edit#gid=1950734539