search

drfaustusfade / ngm-reportDesk

The workdesk for ReportHub
0 stars 1 forks source link

to consider adding pagination on monthly reports and infinite scroll for suitable lists #53

Open drfaustusfade opened 3 years ago

drfaustusfade commented 3 years ago

for example every 50 form elements

also, to consider using infinite-scroll for other lists like target beneficiaries, target locations

fakhrihawari commented 3 years ago

Already try the infinite scroll on target beneficiaries and target location. But for monthly report using pagination .there list in list in monthly report, i mean there are list beneficiaries inside list location . some case in monthly report :

we want to paginate just based beneficiaries or location too?

drfaustusfade commented 3 years ago

that's exactly the point with monthly paginations, that is something to research for the best interface i think as locations are static (except the case when locations are added) they can be paginated for example 20 per page, and beneficiaries on each location also (for example 10), so that in total maximum could be 200 forms per page but that can add complexity, also to check how that would affect location search

drfaustusfade commented 3 years ago

looks good for target beneficiaries and locations I think we can use it why LOCATION_COUNT is used for beneficiaries? does it affect forms to be expanded/collapsed?

drfaustusfade commented 3 years ago

let's also try to migrate monthly reports to use infinite scroll in place of increment location implementation code

fakhrihawari commented 3 years ago

looks good for target beneficiaries and locations I think we can use it why LOCATION_COUNT is used for beneficiaries? does it affect forms to be expanded/collapsed?

LOCATION_COUNT:just number when to load the data ; i just used to try the ng-infinite scroll no i,s not affect the form expanded/collapsed

fakhrihawari commented 3 years ago

Mock up for monthly report pagination for beneficiaries (Just experiment) 192 168 33 16_desk_ (38)

drfaustusfade commented 3 years ago

looks good

fakhrihawari commented 3 years ago

so we add pagination on beneficiaries? this is for infiinity scroll in target location,target beneficiaries and location onmonthly report: https://github.com/fakhrihawari/ngm-reportHub/tree/infinity-scroll-temp

fakhrihawari commented 3 years ago

demo pagination on monthly report

https://user-images.githubusercontent.com/12655589/108824382-39f8aa80-75f4-11eb-8072-ffc75a00f681.mp4

fakhrihawari commented 3 years ago

branch fo infinity scroll https://github.com/fakhrihawari/ngm-reportHub/tree/infinity-scroll-temp if yu okay i will make PR

drfaustusfade commented 3 years ago

I think we should also add infinite scroll to stock monthly report and warehouses as sometimes there are many locations

drfaustusfade commented 3 years ago

branch fo infinity scroll https://github.com/fakhrihawari/ngm-reportHub/tree/infinity-scroll-temp if yu okay i will make PR

a comment to check on pull request