drfaustusfade / ngm-reportDesk

The workdesk for ReportHub
0 stars 1 forks source link

non site based reporting #58

Open drfaustusfade opened 3 years ago

drfaustusfade commented 3 years ago

to check if we can have a location without site_id and site_name

drfaustusfade commented 3 years ago

alright, there seem to be some bugs, please test and compile test cases conducted also please split NG enabling non-mandatory input, in a separate commit location form yes/no site selection into a separate commit and for now not enable site yes/no selection for ET,

I had on adding location chrome_6gUXG6ORgC

on changing site yes/no chrome_11E1uhok8G

also for some reason next chrome_xnT44EkB9N after save chrome_x2OxjWGu48

fakhrihawari commented 3 years ago

Miss that one , i will try solve this and push it as soon as posible, and "now not enable site yes/no selection for ET" i think on master already like that

fakhrihawari commented 3 years ago

Fix it like this

https://user-images.githubusercontent.com/12655589/109267733-a1a13680-783c-11eb-80df-8842232fdc7d.mp4

and sometime the site name not appear coz the type of site_id in location and in the list not same like below

Screen Shot 2021-02-26 at 14 36 24

is just on my local all in prod too?

link : https://github.com/fakhrihawari/ngm-reportHub/tree/non-site_id-site_name

if you okay, i will make separate commit for NG

fakhrihawari commented 3 years ago

NOTE: Some admin2,admin3 code in AdminSite is different from list Admin2List and admin3list in admin2list

Screen Shot 2021-03-01 at 10 18 09

in adminSIteList

Screen Shot 2021-03-01 at 10 17 53

So if we select site_name from list it become like this

Screen Shot 2021-03-01 at 10 19 45
fakhrihawari commented 3 years ago

Link Hide Feature "Site?": https://github.com/fakhrihawari/ngm-reportHub/tree/non-site_id-site_name