search

drfeelngood / resque-batched-job

Resque plugin that understands individual jobs can belong to something bigger than themselves
https://rubygems.org/gems/resque-batched-job
MIT License
49 stars 23 forks source link

Remove dependence on Resque::Helpers #23

Closed subdigital closed 9 years ago

subdigital commented 9 years ago

Resque::Helpers is deprecated and goes away in Resque 2.0. Using it with latest from 1-x-stable branch gives you a repeated warnings in the console.

This pulls in the 2 methods that are being used and removes the dependence on the deprecated modules.

drfeelngood commented 9 years ago

<#<NoMethodError: undefined method 'decode' >>

Finished in 0.711843 seconds.

14 tests, 11 passed, 3 failures, 0 errors, 0 skips, 60 assertions

It looks like we need the decode method as well.

drfeelngood commented 9 years ago

Side note: If you rebase my master branch the travis-ci builds should work as expected. I was a little behind on updating the configuration.

subdigital commented 9 years ago

Will do, thanks.

On Jan 18, 2015, at 7:50 PM, daniel notifications@github.com wrote:

Side note: If you rebase my master branch the travis-ci builds should work as expected. I was a little behind on updating the configuration.

— Reply to this email directly or view it on GitHub https://github.com/drfeelngood/resque-batched-job/pull/23#issuecomment-70437568.