search

drfiemost / Hurrican

A fork of Hurrican, freeware jump and shoot game created by Poke53280, with SDL2 enabled by default, support for libopenmpt and CRT simulation
MIT License
7 stars 2 forks source link

Tutorial level crashes in gamepad control. #9

Closed s1eve-mcdichae1 closed 2 years ago

s1eve-mcdichae1 commented 2 years ago

Issue not present with keyboard control. With gamepad "0:Logitech Gamepad F710" it crashes in the same place every time (as I start to walk down the hill after the destructible wall where the smartbomb is demonstrated.)

I was told to do a gdb backtrace. I think I did that. Does this look like what you need? https://pastebin.com/yabpdLPu

(I was having trouble with the --args syntax so I managed this by running it from the data dir with gdb build/hurrican -ex run and when that seemed to work, I captured the log by adding |& tee gdblog.txt.

If that isn't what you need, I'll need you to explain it like I've never done this before because, well, I haven't.)

drfiemost commented 2 years ago

Sorry, I forgot to say that you need to use the bt command from the gdb console to get the full backtrace.

s1eve-mcdichae1 commented 2 years ago

Issue not present on joystick_pause branch (though there's another issue, which I will address there); I was able to complete the tutorial level. I will follow-up if it resurfaces. (Or would it be helpful to recompile the old version and trace the crash anyway?)

s1eve-mcdichae1 commented 2 years ago

...also fixed in master (446b7a1).

drfiemost commented 2 years ago

Excellent, thank you!

s1eve-mcdichae1 commented 2 years ago

I checked, it was still present in 444a4d7 but not in 446b7a1 so it must have been related to #8 somehow.

drfiemost commented 2 years ago

Yes, it was writing outside a memory buffer bounds causing problems.