Fixed issue with UniqueList and portals creation

drfrag666 / gzdoom

GZDoom adds an OpenGL renderer to the ZDoom source port.

http://gzdoom.drdteam.org

GNU General Public License v3.0

73 stars 15 forks source link

Fixed issue with UniqueList and portals creation #27

Closed emawind84 closed 3 years ago

emawind84 commented 3 years ago

fixed issue with UniqueList Added memset after creation of new pointer. This was causing massive drop of framerate on Oculus Quest (Android) when looking outside, with multiple GLSkyInfo object created, memcmp always failed with return -1 when dealing with GLSkyInfo
added option to switch on/off the skydome in display options
when the skydome is disabled the background color will match the color of the texture of the skydome to keep some immersion during gameplay

emawind84 commented 3 years ago

Currently the skydome on/off option works only when using opengl rendering. I should probably move the option in the opengl settings.

drfrag666 commented 3 years ago

Yes, it should be under OpenGL options. Have you used UTF-8 without BOM? Could you combine both commits into one?

emawind84 commented 3 years ago

Yes, it should be under OpenGL options. Have you used UTF-8 without BOM? Could you combine both commits into one?

I will check the encoding and do the pull request again I will move the option in the opengl options

drfrag666 commented 3 years ago

You can force push to the same branch. For me performance with skyboxes is fine on windows, are you sure this is not an android specific issue?

emawind84 commented 3 years ago

You can force push to the same branch. For me performance with skyboxes is fine on windows, are you sure this is not an android specific issue?

The toggle for the skydome helps a lot on android, regarding the uniquelist, the issue is present on android, from my test, but not on pc, the implementation seems not correct nevertheless. Feel free to do the edit for the uniquelist if you want. Pull request for one line of code is pointless.

alexey-lysiuk commented 3 years ago

Pull request for one line of code is pointless.

You are wrong. Number of changed lines has nothing to do with PR's usefulness. It's a bad idea to modify unrelated code in one PR. When all changes serve one purpose, and do it right, number of lines is a pointless metric.

emawind84 commented 3 years ago

Pull request for one line of code is pointless.

You are wrong. Number of changed lines has nothing to do with PR's usefulness. It's a bad idea to modify unrelated code in one PR. When all changes serve one purpose, and do it right, number of lines is a pointless metric.

You are right, just bad use of words on my part, just let me know if I should make a pr for the changes regarding the UniqueList class.