Missing cmdlib.h include in src/posix/i_steam.cpp

drfrag666 / gzdoom

GZDoom adds an OpenGL renderer to the ZDoom source port.

http://gzdoom.drdteam.org

GNU General Public License v3.0

74 stars 17 forks source link

Closed OrdinaryMagician closed 5 years ago

OrdinaryMagician commented 5 years ago

Won't build on Linux without this.

drfrag666 commented 5 years ago

I just saw your message yesterday. Really? The include is there, which error do you get?

OrdinaryMagician commented 5 years ago

You can close this if this no longer applies. :P

OrdinaryMagician commented 5 years ago

Reopening because I just realized that it's still happening.

src/posix/i_steam.cpp:208:7: error: ‘FileExists’ was not declared in this scope
   if(!FileExists(regPath))
       ^~~~~~~~~~

This is specifically in the default branch.

drfrag666 commented 5 years ago

I see you're compiling ZDoom32, i forgot it was still the default branch. Please try now, it should compile. Same problem with ZDoom LE.

OrdinaryMagician commented 5 years ago

Ah, after this I'm seeing there's also an issue with oalsound.cpp. It appears that including <functional> is needed for std::mem_fn.

drfrag666 commented 5 years ago

Fixed, should compile now. But that code is very old and the include was added much later. I'd swear it compiled for me.

OrdinaryMagician commented 5 years ago

Well, that's it then.

drfrag666 commented 5 years ago

Have you tried to compile the g3.3mgw branch (LZDoom)? That would be really helpful. I'll do a new release very soon.

drfrag666 commented 5 years ago

Never mind, i hooked the Travis-CI service.