vote will sometimes not display for a player

[GoogleCodeExporter]

What steps will reproduce the problem?
N/A

What is the expected output? What do you see instead?
The vote will sometimes not appear for a subset of players. All players should 
see the vote.

Please use labels and text to provide additional information.

Galileo thinks there is currently a menu showing for the player and thus, waits 
it's turn. However, there is no menu showing and therefore Galileo never 
displays. In the previous version, Galileo didn't care if another menu was 
showing, it would just overwrite any existing menus. In the current version, I 
changed it to be more considerate (as explained earlier). Neither solution is 
optimal. Best solution might be to give each server the option of how they want 
it handled.

Original issue reported on code.google.com by jones.p....@gmail.com on 19 Dec 2010 at 4:35

[GoogleCodeExporter]

A player suggested that if a vote hasn't been received by a player after a set 
time (perhaps half of allowed time) to assume that the player's vote menu was 
overwritten and to redisplay it.

Original comment by jones.p....@gmail.com on 19 Dec 2010 at 4:40

[GoogleCodeExporter]

I think I'm going to make it an aggressive/passive option. The aggressive 
option meaning it'll overwrite any menu that is currently displayed. The 
passive option meaning if Gal thinks a menu is being displayed already, it'll 
wait until the menu (or menu artifact) goes away.

Original comment by jones.p....@gmail.com on 26 Dec 2010 at 2:32

[GoogleCodeExporter]

NO! I've got it! When the vote gets displayed to everyone, print a message 
indicating as such into client_chat with instructions of pressing a key if they 
don't see the vote. Once they press a key, throw up a menu, take it down, do 
whatever it takes to force our menu to be shown. Someone had commented in the 
Gal thread at AMXX that the vote was supposed to display but it didn't, he went 
into amxmodmenu (or some such) and when he came out, there was our menu.

Original comment by jones.p....@gmail.com on 26 Dec 2010 at 5:53

[GoogleCodeExporter]

"he went into amxmodmenu" ... yep, that was me who said it (in forum, my nick 
is RTG)... I think that things in comment 2 and 3 are good, but i think that in 
comment 2, the aggressive way will be better, because many players (if i could 
say - noobies) don't care/know that any vote has to be appeared (no 
sound/blind, they don't read the chat) or they are pulled into the game that 
much so they do not notice that the vote has to be appeared... but the best way 
can be the optional, 1) - passive, 2) - aggressive, 3) - as you say in comment 
no.3 (but these instructions.. hmm.. i dont know.. maybe it can be good) ... 
sry for my english if it is bad, hope my opinion helps :)

Original comment by hop...@gmail.com on 27 Dec 2010 at 12:02

[GoogleCodeExporter]

hmm I overlooked the first comment, that will be very good for the aggressive 
mod, after amount of time to redisplay the vote, it could minimalize these bugs

Original comment by hop...@gmail.com on 27 Dec 2010 at 12:13

[GoogleCodeExporter]

The problem with comment #1 is that even after half the allowed time, Gal still 
won't be able to determine if the player is really being shown a menu, if the 
server says they are.

I am currently working on resolving this issue. What I'm doing is only showing 
a "press 'x' to vote" message to players who Gal did not show the vote to. In 
theory, that means very few people will ever see it. If the player presses 'x' 
in enough time, I'll force the vote to display.

Original comment by jones.p....@gmail.com on 27 Dec 2010 at 12:18

[GoogleCodeExporter]

I forgot to mention that there will be a CVAR that will allow you the following 
options:

When a vote for the next map begins...
 - force the vote menu to overwrite any existing menu
 - display the menu to anyone who doesn't have a menu already up, but let the other players opt in

Original comment by jones.p....@gmail.com on 27 Dec 2010 at 6:16

[GoogleCodeExporter]

the "force" method is good i think

Original comment by hop...@gmail.com on 28 Dec 2010 at 2:20

[GoogleCodeExporter]

Stopped work on it. Was getting too involved. In the meantime, trying a 
different method of detecting an existing menu. Anyone interested in testing it 
needs to get ahold of me.

Original comment by jones.p....@gmail.com on 1 Jan 2011 at 10:29

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Closed wrong issue. Trying again...

Original comment by jones.p....@gmail.com on 20 Jan 2011 at 7:39

• Changed state: Started

[GoogleCodeExporter]

This issue was closed by revision r103.

Original comment by jones.p....@gmail.com on 20 Jan 2011 at 7:45

• Changed state: Fixed

[GoogleCodeExporter]

good work, thanks alot, i did not tested it yet but i hope it works fine or at 
least better than before ;)

Original comment by hop...@gmail.com on 20 Jan 2011 at 9:00

[GoogleCodeExporter]

We were using the aggressive option, but there is a problem with that. It does 
not allow the displaying other menus at all, and it was being used in a mod 
that relied on other menus (think Zombie Plague, with buy menus). Maybe a third 
option, that aggressively displays the first menu but only passively redisplays 
it (i.e. it allows other menus to overwrite this one)?

Original comment by elusive...@gmail.com on 8 Oct 2011 at 10:28

[GoogleCodeExporter]

the plugin has been updated? anyway, i am awaiting next release of this plugin, 
it hasnt been updated for a years :(

Original comment by hop...@gmail.com on 17 Oct 2011 at 11:35

[GoogleCodeExporter]

elusive, the third option, as you've described, sounds viable. I'll look into 
it.

A little info on what's going on...

If you have Galileo show the progress of the vote, via CVAR 
gal_vote_showstatus", it'll attempt to redisplay the menu every second of the 
vote. If you're not showing progress, it'll attempt to display the menu at the 
start at the vote, optionally every second starting after a player votes, and 
then optionally at the end of the vote.

Every time it tries to redisplay the menu, it checks to see if AMXX is 
reporting that there's a menu already being displayed. This is where the new 
CVAR comes in. 

Original comment by jones.p....@gmail.com on 20 Feb 2015 at 2:32

• Changed state: Started

[GoogleCodeExporter]

Have added the third option, Galileo will overwrite any menus up when it first 
displays, but will not overwrite any after that.

This was fixed in r117.

Original comment by jones.p....@gmail.com on 23 Feb 2015 at 4:14

• Changed state: Fixed