drg-tools / drg-weapons-calculator

A passion project to optimize Deep Rock Galactic weapon builds
51 stars 6 forks source link

Incorrect damage calculation for hyper propellant+incindiary compound Deepcore PGL. #61

Closed adsadijbk closed 1 year ago

adsadijbk commented 2 years ago

the direct / area damage for hyper propellant should not be reduced by 50%, but heat should still be applied. This was changed around update 32. This has been observed by several members of the reddit / discord. This retains damage exclusively with hyper propellant.

Steps to reproduce the behavior:

  1. Go to Deepcore PGL
  2. Loadout 2 1 0 1 2 hyper prop
  3. now 2 1 1 1 2 hyper prop
  4. See error (should not decrease damage, instead should add heat).

Expected behavior flat heat damage bonus, with max damage build (no damage reduction).

Desktop (please complete the following information): windows. irrelevant, this is an issue with the calculator.

Additional context Add any other context about the problem here.

adsadijbk commented 2 years ago

in discord the actual damage calculation to a praetorian (assuming 140% damage, all .3s fire ticks, frozen ifg'd enemy) was estimated to be 3046 (3045.9) from the calculation ((445x3+110)x1.4+120+200)x1.3 ((DDxfrozen+AD)xhomebrew+burn+temp shock)xIFG (DD is marked incorrectly as 310 on the calc it is 445 in-game)

phg49389 commented 2 years ago

@adsadijbk

Which version of the DPS Calculator are you using? I just checked it on v1.1.2a, the last release I had put out and Incendiary Compound doesn't affect Hyper Propellant and only increases the total damage, like it should.

phg49389 commented 1 year ago

Closing due to inactivity. The Hyper Propellant / Incendiary Compound conversion bug is going to be modeled correctly in the next release, along with the other >100% conversion bugs.