add feature to response pdf by file name (resolve #12)

drgarcia1986 / drf-pdf

A simple PDF utils for Django Rest Framework

MIT License

25 stars 9 forks source link

add feature to response pdf by file name (resolve #12) #19

Closed drgarcia1986 closed 9 years ago

landscape-bot commented 9 years ago

Repository health decreased by 3% when pulling 0491b00 on response-by-filename into 6733363 on master.

10 new problems were found (including 1 error and 0 code smells).
No problems were fixed.

landscape-bot commented 9 years ago

Repository health decreased by 3% when pulling 0491b00 on response-by-filename into 6733363 on master.

10 new problems were found (including 1 error and 0 code smells).
No problems were fixed.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 0491b008febd429051ace80649203b44ec0d6438 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

drgarcia1986 commented 9 years ago

something more Coveralls ? LOL

jairhenrique commented 9 years ago

@drgarcia1986 you forgot the documentation :smile:

landscape-bot commented 9 years ago

Repository health decreased by 5% when pulling e51f908 on response-by-filename into 6733363 on master.

15 new problems were found (including 1 error and 0 code smells).
No problems were fixed.

drgarcia1986 commented 9 years ago

@jairhenrique done (after one month). Guys, can you help me with typos and english errors in documentation? ( @jairhenrique and @renanivo )

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling e51f9081978ba19bb1a4c9bffada64a737fb2797 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

renanivo commented 9 years ago

We could also add headers before the description of PDFResponse and PDFFileResponse like DRF's documentation does.

drgarcia1986 commented 9 years ago

@renanivo I think its awesome, but we could make also this on another improvement (with a changelog for example).

landscape-bot commented 9 years ago

Repository health decreased by 5% when pulling 234a40f on response-by-filename into 6733363 on master.

15 new problems were found (including 1 error and 0 code smells).
No problems were fixed.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling 234a40f31e465186983fc8f84bd21625b8500159 on response-by-filename into 6733363fbf47333460cf952ca7cd721efae53376 on master.

renanivo commented 9 years ago

Ok :shipit: