Wonder Trade bot unreliable behaviour

drgoku282 / PKMN-NTR

A Pokémon on-the air memory editing/reading program with bots for Nintendo 3DS.

http://gbatemp.net/threads/pkmn-ntr-real-time-memory-editing-program-for-pok%C3%A9mon-games-wip.448588/

GNU General Public License v3.0

90 stars 24 forks source link

Wonder Trade bot unreliable behaviour #154

Open ghost opened 6 years ago

ghost commented 6 years ago

Tested on old 3DS, all installed firmware and software is up-to-date to their latest revisions.

Running bot with following settings:

wonder-trade-bot

With only one Pokémon present in the folder.

The following behaviour can occur after a few trades:

The bot will leave the Wonder Trade Start screen instead of proceeding to the box.
The Pokémon in the current selection slot gets traded instead of the one in the Wonder Trade folder.
The bot will error asking to return to the Wonder Trade Start screen and to start again.
The device will freeze permanently on a "saving" screen.

Tested on Pokémon Ultra Moon v1.2.

ghost commented 6 years ago

It seems the 30 second bot wait once a trade is starting is too little. I think raising it to 32 might fix this issue, or 35 if you really want to be safe.

ghost commented 6 years ago

I compiled it with a 40 second time out, it seems to be safe. The ultimate solution would be to just detect when it gets back to the start screen of course, without having to deal with risky time out values.

35 seconds even caused issues, because sometimes when saving after a trade, it can happen quickly, or it can take a few seconds extra, and when the bot tries to continue then, it will result in the game to freeze entirely.

TL;DR: 40 seconds timeout instead of 30 seconds (or remove timeout and detect when back at start)

D35P4C1T0 commented 6 years ago

Do you mind sharing your 40 seconds build?