drgrib / alfred-bear

Streamlined note searching and creation for Bear using Alfred
MIT License
427 stars 24 forks source link

Build with ICU #31

Closed drgrib closed 4 years ago

drgrib commented 4 years ago

The suggested solution for using lower() on unicode characters found in the SQLite documentation is to [install the ICU extension](https://www.sqlitetutorial.net/sqlite-functions/sqlite-lower/#:~:text=The%20SQLite%20lower()%20function,ICU%20extension%20of%20this%20function. ). I've followed the install and build instructions for using ICU with go-sqlite3.

This ICU build version successfully searches for lowercase Cyrillic letters with uppercase.

image

I cannot, however get it to search for uppercase using lowercase. @kudrykv if you can provide test strings or suggestions, I can test further.

kudrykv commented 4 years ago

Answered here: https://github.com/drgrib/alfred-bear/pull/30#issuecomment-682332472

The reason I wanted it to be in the code is the simplicity of installation. I'm really sorry it doesn't work for you. If you could provide more information what you did and what went wrong, maybe I would be able to fix the code.

Also, would you be interested in covering the code with tests? I am willing to do that from time to time.

drgrib commented 4 years ago

@kudrykv This situation has me considering tests, yeah. That's a good point about the simplicity of installation. And even my ICU version won't work with searching for СВІДОЦТВО using свідоцтво.