search

drgullin / icheck

Highly customizable checkboxes and radio buttons (jQuery & Zepto)
http://fronteed.com/iCheck
7.38k stars 1.62k forks source link

Add event delegation support #36

Closed shinuza closed 11 years ago

shinuza commented 11 years ago

iCheck will not forward events when using event delegation, check this for reference:

Regular inputs:

http://codepen.io/anon/pen/dcIoh

iCheck inputs:

http://codepen.io/anon/pen/ktyvG

iCheck needs to forward those events to the underlying input

drgullin commented 11 years ago

iCheck doesn't support click event on inputs because of the nested labels support (inputs directly inside labels and labels inside labels). You may use callbacks and methods instead.

shinuza commented 11 years ago

This impairs iCheck capabilities of being a drop in replacement for regular inputs

joangrigorov commented 11 years ago

I support shinuza's comment. We also have much problems with this. We have a lot of plug-ins that use the classic change event and if we update all plugins (which is not a quick job) we end up with plugins depending on iCheck, which is not good.

kasperisager commented 11 years ago

Any news on this?

drgullin commented 10 years ago

Prepared for the next version.

kasperisager commented 10 years ago

:thumbsup: