Open nigelwhite opened 2 years ago
Having same issue, a patch is out here for webform contrib module who is requiring this jquery/icheck library : https://www.drupal.org/project/webform/issues/3264249
This potentially breaks the deployment of tens of thousands of websites using the webform module for Drupal. The root cause is that https://github.com/dargullin/icheck/archive/1.0.2.zip returns this weird error:
the given path has multiple possibilities: #<Git::Ref:0x00007f0f498260b8>, #<Git::Ref:0x00007f0f49825b68>
Edit: the problem is caused by the fact that 1.0.2
is both a tag and a branch
@prudloff-insite installing the patch (for webform 6.1.2 at least) will resolve the issue for now as long as you make sure the composer lock file is updated correctly. I would not be surprised if updating webform will be the solution to this problem since the webform module links to github/fronteed which in turn links to this repo.
The webform patch does indeed fix the issue but it will require patching a lot of websites. In the mean time, renaming the 1.0.2 branch could instantly fix the problem for everyone.
Please remove the branches with the same name as tags.. A tag can be somewhat considered a 'named branch'. If you ever need to checkout 1.0.1 simply do that: git checkout 1.0.1
. It just works.
Deleting the 1.0.2 and 1.0.3 branches will fix the Github release URLs: https://github.com/dargullin/icheck/archive/1.0.2.zip
To the team managing this project:
This issue causes a big problem while upgrading a Drupal website to v9.
Please fix this right away.
This is breaking the developer workflow of anyone trying to use this package. Please remove the branches for 1.0.2
and 1.0.3
.
this patch for webform worked for us https://www.drupal.org/files/issues/2022-02-14/3264249-6.2.x.patch
@dargullin sorry for the direct ping but this is still broken.
I also got bit by this today. Please fix.
Having the same issue.
Removing icheck
's entry in my project's composer.lock
file and then re-running composer install
fixed the issue for me.
Yes, we have been deleting composer.lock file and re-running composer update. Also removed the patch from composer.json
Gordon Belray Information Architect University of Toronto Libraries @.**@.> 416-427-7007
On Feb 24, 2022, at 11:04 AM, Eric J. Gruber @.**@.>> wrote:
Having the same issue.
— Reply to this email directly, view it on GitHubhttps://github.com/dargullin/icheck/issues/437#issuecomment-1050009918, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAXFA5QFKA4TCS3QE4HKINDU4ZJILANCNFSM5OLCPZ5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.Message ID: @.***>
Please remove the branches.
Same here, please remove branches
Same issue.
In the composer.lock
file I tried replacing https://github.com/fronteed/icheck/archive/1.0.2.zip
with https://github.com/dargullin/icheck/archive/refs/tags/1.0.2.zip
and it worked when running composer install
. It is not a perfect solution. Got the idea from https://www.drupal.org/project/webform/issues/3264249#comment-14422171
yep, same here for both Drupal 8 and Drupal 9. gonna go with @jaylenw hack, its not nice but it works. Better if you re-name the branches not to be the same as the tags.
I did
composer require --dev drupal/core-dev:8.9.20 --update-with-all-dependencies
Composer starts installing stuff but then errors