search

drhagen / tensora

Sparse/dense tensor library for Python
http://tensora.drhagen.com/
MIT License
9 stars 2 forks source link

Make output format optional in evaluate #43

Open drhagen opened 10 months ago

drhagen commented 10 months ago

The output_format parameter should be optional in evaluate and default to all dense. This is a common enough choice and we default to all dense other places.

drhagen commented 9 months ago

We should probably remove output_format entirely and put it into the **kwargs that currently captures all the intputs. The output would be specified by name instead of being the positional argument. It would be typically be optional, defaulting to "all dense". It could also be a Tensor, in which case the output format and dimensions would match the Tensor provided. The dimensions would be checked against the matching dimensions of the input Tensors. If there was a broadcast dimension, this argument would not be optional and it must be a Tensor which would provide the necessary size.