drhelius / Gearcoleco

ColecoVision emulator for macOS, Windows, Linux, BSD and RetroArch.
https://x.com/drhelius
GNU General Public License v3.0
62 stars 15 forks source link

libretro: Add no sprite limit core option #30

Closed msheehan79 closed 12 months ago

msheehan79 commented 12 months ago

This PR implements a No Sprite Limit core option to the Libretro core, to turn off the 4 sprite per line limitation that is present on original hardware which results in less sprite flicker.

A good test case I used was "BurgerTime" as this game introduces some very notable flickering immediately upon starting, and the core option removes this.

I did not add a getter method as the libretro implementation does not utilize one, and I was not sure if you would prefer an inline function or not as some of the other getters use.

drhelius commented 12 months ago

Awesome. Thanks a lot for your work.

Just two things:

msheehan79 commented 12 months ago

Thanks for the feedback and pointers on these - I will adjust soon.

msheehan79 commented 12 months ago

@drhelius I've incorporated your feedback into the PR.

I also had originally had the flag getting set to false in the Reset() method which I had to remove, as I realized that method gets called after Libretro sets the flag, so it would keep getting reset until you went back into Core Options and toggled it off and on again.

drhelius commented 12 months ago

Nice! Thanks again.