drhelius / Gearsystem

Sega Master System / Game Gear / SG-1000 emulator for macOS, Windows, Linux, BSD and RetroArch.
https://x.com/drhelius
GNU General Public License v3.0
247 stars 45 forks source link

Output image is not pixel perfect #57

Closed Jaffacakelover closed 2 years ago

Jaffacakelover commented 2 years ago

Gearsystem 3.4.1, Windows 10 Home x64. Filtering off, ghosting off, scanlines off. Square pixels ratio (although nothing changes when 4:3 is set).

Zooming in on the title screen of Bank Panic, you can see that the scaling / display is not pixel perfect, aliasing edges of both the game image and the edges of the game window: Bank Panic x3 x4 1 3x scale, 400% zoom

It doesn't scale cleanly up from / down to 256x192. Even 1x (actual size) isn't a crisp picture: Bank Panic x1 x4 1 1x scale, 400% zoom

How it should look when zoomed in: Bank Panic 1x 4x clean 1x scale, 400% zoom, from another emulator

drhelius commented 2 years ago

Thanks for reporting, I'll take a look

drhelius commented 2 years ago

I can't reproduce the issue. I tested on Windows and Linux and got pixel prefect images. What resolution are you using?

drhelius commented 2 years ago

I was able to reproduce it by setting the Windows scale (Settings > System > Display) to a value higher than 100% Is that your case?

Jaffacakelover commented 2 years ago

Yes, that's it! My laptop was set to 125% scale, and setting it to 100% solved the problem.

Looking at the emulator I was comparing Gearsystem to, it looks like they've implemented it so that the menu bar etc. scales with that DPI setting, but the game window stays the same size (and pixel perfect) regardless!

biz-100 Scale 100%

biz-125 Scale 125%

drhelius commented 2 years ago

OK! I'll fix it so it renders correctly even at 125%