search

drhenner / fit

Other
0 stars 0 forks source link

Single Sign On #223

Open khurramzaman opened 11 years ago

spectator commented 11 years ago

Even thought there is a lot of things we don't need, I think we can live with that for now. The next step we need to do is to figure out how to migrate users to Launchpad. After that we can deploy this to stage to properly test.

Launchpad itself should be 100% ready by the end of the next week, so let's keep this pull request open for now.

kylecrum commented 11 years ago

Looks pretty good, @khurramzaman ! Let us know when you resolve the comments mentioned here.

kylecrum commented 11 years ago

@spectator , would it be best to have a "user data migration" branch that we can merge into this sso branch so that it's done in one full swoop?

drhenner commented 11 years ago

@kylecrum "user data migration" would only work if the encryption type is the same. That said... @spectator What is the encryption algorithm?

spectator commented 11 years ago

Yes, that would be the best. @opti will look into users migration, hopefully that wouldn't be a big pain. In case it's impossible due to different encryption algorithms, we will have to find a different way, probably by involving real users.

On Apr 17, 2013, at 12:00 PM, Kyle Crum notifications@github.com wrote:

@spectator , would it be best to have a "user data migration" branch that we can merge into this sso branch so that it's done in one full swoop?

— Reply to this email directly or view it on GitHub.

spectator commented 11 years ago

@khurramzaman please go ahead and push this branch (do not merge it anywhere, just make sure it has master merged in) to staging so we can test it.

spectator commented 11 years ago

BTW, Launchpad now returns country, so make sure it's set in ror-e https://github.com/RoR-ecommerce/ufc-launchpad/blob/master/INTEGRATION.md#obtaining-user-information

spectator commented 11 years ago

BTW, I don't know how it's done in ror-e, but if it's there please disable sign-up email notification, otherwise users will get it twice.