search

drhenner / ror_ecommerce

Ruby on Rails Ecommerce platform, perfect for your small business solution.
www.ror-e.com
MIT License
1.21k stars 409 forks source link

Payment Decline creates an invoice #116

Closed DTwigs closed 10 years ago

DTwigs commented 11 years ago

I have an issue where if you submit an order and the credit card stuff is wrong, the payment is decline but it still creates an invoice. When you successfully check out there are now two invoices tied to the same order. One with Authorized and one with Payment Declined. This really screws up the order page because sometimes the status of the "Payment Declined" invoice is loaded and you can't "Collect" the payment.

drhenner commented 11 years ago

I actually thought this was the right thing to do when I started (hence I have a log of a failed creditcard) but now I think you are right.. I shouldn't have the invoice record... I need more time to change this

DTwigs commented 11 years ago

Oh ok, yeah I mean, the invoice creation isn't even that big of a deal. It's more that sometimes when showing the order it thinks that the payment has been declined when it hasn't. The reason is because there are two invoices associated with that order, and one has been declined.

drhenner commented 11 years ago

I'll try to change soon. I'm knee deep in issues at work right now.

drhenner commented 10 years ago

I just fixed this. such an easy fix and I took so long. Thanks for posting this.