form not reloading CC exp date when processing fails

drhenner / ror_ecommerce

Ruby on Rails Ecommerce platform, perfect for your small business solution.

www.ror-e.com

MIT License

1.21k stars 409 forks source link

form not reloading CC exp date when processing fails #139

Open deco81 opened 10 years ago

deco81 commented 10 years ago

After submitting my fraudulent credit card I am returned to the form displaying errors. However the year and month on the cc number I entered have been reset to 01/14.

Also the default expiry date should probably be the current month/year

drhenner commented 10 years ago

I had a debate with myself about this. On one hand is UI on the other hand is sending the least amount of secure data. If you like the idea of the CC month/year being set I can fix that. I don't have a strong opinion.

Thanks for the feedback... I will hopefully have time on Saturday. (depends on my friends)

deco81 commented 10 years ago

That's an interesting thought regarding minimizing the amount of sensitive data being sent back to the client. I think the way a lot of sites do it is to send back the number and expiry but clear the CVV.