search

drhenner / ror_ecommerce

Ruby on Rails Ecommerce platform, perfect for your small business solution.
www.ror-e.com
MIT License
1.21k stars 409 forks source link

bring dialog to front and change dialog title #177

Closed sullivanLi closed 7 years ago

sullivanLi commented 7 years ago

screenshot

When I open the dialog, it can't click or see clearly. I tested it on Chrome and Firefox. I'm not sure if you have the same problem, so I just added z-index to prevent other people having the same problem. Moreover, the dialog title default value is "Cancel Invoice". It'll be nicer to change the title according to which button I clicked.

drhenner commented 7 years ago

I'll take a look. I'll try to merge once i test (probably this weekend)

BTW: If you are interested I can give you commit rights

sullivanLi commented 7 years ago

Thank you, David I'm interested in this project and I wanna gain more experience in RoR and open source project. If you have something wanna enhance or some issue wanna fix, please let me know. Otherwise, I'll try to fix this issue https://github.com/drhenner/ror_ecommerce/issues/174 If you're already working on it, please let me know, too.

sullivanLi commented 7 years ago

sorry, I should create another branch, my commit mixed with previous PR.

sullivanLi commented 7 years ago

Hi @drhenner, would you like to review my changes, I also add some tests, Thank you.

drhenner commented 7 years ago

@sullivanLi I'll look this weekend. Sorry for the delay I have been swamped at work

drhenner commented 7 years ago

Thanks for the work @sullivanLi I made a few minor comments. I'll be happy to make the changes myself if you are busy 😃

sullivanLi commented 7 years ago

Thanks for reviewing my code @drhenner. I'm a little busy this week, please feel free to change my code.