search

drhenner / ror_ecommerce

Ruby on Rails Ecommerce platform, perfect for your small business solution.
www.ror-e.com
MIT License
1.21k stars 409 forks source link

Variant Brand ? #19

Closed rubydesign closed 10 years ago

rubydesign commented 12 years ago

Shouldn't the brand be a property of the Product rather than the Variant.

I don't understand what it would mean to have one product with variants from different brands.

(btw: nice though that brands and suppliers are not the same)

drhenner commented 12 years ago

I debated this for a while. Then I had one use-case where the brand was different for individual variants. I could forced the business guy to make a separate product and relate the products somehow.

I'll keep this open and ask others what they feel. I'm thinking one "weird" use-case isn't worth accommodating. I might change after my Dec 3rd meetup.

drhenner commented 12 years ago

I just realized. I could have a brand on product and variant. If the variant brand_id is nil it will default to the product's brand.

rubydesign commented 12 years ago

Possible. But is it useful? What was that case you had, because I really can't imagine it.

On 27.11.2011, at 18.57, David Henner wrote:

I just realized. I could have a brand on product and variant. If the variant brand_id is nil it will default to the product's brand.

Reply to this email directly or view it on GitHub: https://github.com/drhenner/ror_ecommerce/issues/19#issuecomment-2888633

drhenner commented 12 years ago

If I remember correctly it was a fashion product. The same product had RL vs Ralph Lauren for the logo. It could have been two products but everything else was identical.

I'm definitely agreeing brand is a product association. I'm going to talk with a few people about this. before i take brand off of variant.

rubydesign commented 12 years ago

Hi, is this still open ?

drhenner commented 11 years ago

I did just write a use case where variant.brand was different than product.brand. Odd use case. They guy was selling medical procedures. Each product was a procedure and each variant was a location the procedure was performed at.

drhenner commented 10 years ago

I'll try to do this tonight. (about time :smile: )

drhenner commented 10 years ago

Done! :smile: