dribnet / pixray

neural image generation
Other
402 stars 53 forks source link

Portrait aspect #22

Closed dginev closed 3 years ago

dginev commented 3 years ago

It is very handy that pixray has such smooth support for both "square" and "widescreen" aspects.

I was wondering if you'd be open to also adding a "portrait" aspect, which would be effective for, well, portraits, but also various vertical compositions (e.g. individual waterfalls, skyscrapers, trees, and so on)

dribnet commented 3 years ago

Sounds like a great idea - I'd vote for a 5 to 4 aspect ratio - sound good? Note that it's possible to manually set size and pixel_size to anything you want, but very easy to screw this up (and nice to have a few settings heavily tested and optimized!) which is why I think having a few preset aspect settings is very helpful. On these settings I also the total pixel area on the settings so that "scale=N" is the same total area for a constant N.

Using that logic, I've gone ahead and added an aspect="portrait" setting in the master branch (example attached). Give it a go and if it seems to work for you we can add it permanently and expose it in some of the notebooks.

portrait_18_09

dginev commented 3 years ago

Indeed, this works quite nicely on my end, thanks for the instant feature! And good to know about size and pixel_size, will experiment with them for some custom ideas.

Enjoy a "handsome robot" as thanks.

Handsome Robot  Trending on ArtStation