dribnet / pixray

neural image generation
Other
402 stars 53 forks source link

pixray.add_settings(drawer="pixel") #7

Closed baldonazionale closed 2 years ago

baldonazionale commented 2 years ago

pixray.add_settings(drawer="pixel")

this setting generates an error:

KeyError: 'pixel'

rvorias commented 2 years ago

Your class_table might not have been updated.

try:
    from clipdrawer import ClipDrawer
    from pixeldrawer import PixelDrawer
    from linedrawer import LineDrawer
    # update class_table if these import OK
    class_table.update({
        "line_sketch": LineDrawer,
        "pixel": PixelDrawer,
        "clipdraw": ClipDrawer
    })
except ImportError:
    # diffvg is not strictly required
    pass

Can you verify if those import statements work?

dribnet commented 2 years ago

Ah yes, I should probably make a more meaningful error message here. The issue is that I want the software to work in VQGAN mode if the gnarly diffvg dependency is not available. But this means that if the dependency fails you don't know about it until you request pixel mode. Perhaps better would be to import the dependency when requested (reporting errors) and not conditionally at the top of the file (ignoring errors).

dribnet commented 2 years ago

going to close this out for now, but feel free to re-open if this happens again and we can track down where to stick in a better error message.