search

driebit / ginger

Ginger: awesome semantic CMS built on Zotonic
http://ginger.nl
Apache License 2.0
29 stars 9 forks source link

httpc request without timeout #680

Open mworrell opened 2 years ago

mworrell commented 2 years ago

In:

https://github.com/driebit/ginger/blob/master/modules/mod_ginger_base/support/ginger_http_client.erl#L57

there is a http:request without any timeouts.

If there is a connect problem then this might hang forever (as the default timeout is infinity). Best is to set a timeout and connect_timeout