search

dries007 / HoloInventory

Hologram inventory for blocks in MC
https://minecraft.curseforge.com/projects/holoinventory
MIT License
19 stars 17 forks source link

Conflict with Applied Energistics #25

Closed Xiaminou closed 7 years ago

Xiaminou commented 7 years ago

Description

Shift-clicking storage cells in the I/O Port causes a fatal error from time to time. 23:58:28: fml-server-latest.txt

https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/2668

Environment

dries007 commented 7 years ago

Looking into it, but it's quite a strange one. Has it only ever happend with the IO ports?

Xiaminou commented 7 years ago

As far as I can remember, yes. Banning the I/O Port from rendering Holo Inventory fixes the problem so it's not a big deal.

dries007 commented 7 years ago

I'll do my best, but I can't promice a definitive fix. ConcurrentModificationException means its a threading problem, and as far as I know, in the context where it happens, it shouldn't be possible. Unless AE does something weird (they probably shouldn't)

Xiaminou commented 7 years ago

Well the I/O Port exports items from the storage cells to the network as soon as it enters it so it might have something to do with that, just guessing.

dries007 commented 7 years ago

Would you mind trying and reporting back? Get the build here: https://jenkins.dries007.net/job/HoloInventory/140/ If you don't have issues anymore, I'll upload it to curse.

Xiaminou commented 7 years ago

still happening: fml-server-latest.txt

dries007 commented 7 years ago

That log still mentions build 139. Please try 140.

Xiaminou commented 7 years ago

Oh right, derp, I changed it on the client and forgot to change on the server.

Xiaminou commented 7 years ago

No crash this time, after 2 tries. Looks fixed, thank you.

dries007 commented 7 years ago

OK, if it does happen again, feel free to reopen.