search

driesvints / vat-calculator

Handle all the hard stuff related to EU MOSS tax/vat regulations, the way it should be.
MIT License
1.2k stars 88 forks source link

Fix rounding of values #147

Closed driesvints closed 2 years ago

AidasK commented 1 year ago

@driesvints Just wanted to point out that such rounding is not always correct since round function poorly handles float values. Example: image Instead we could use bcmath function or return float value as before and leave this issue for the implementation app.

driesvints commented 1 year ago

Thanks @AidasK. Would welcome a PR with some tests