search

driesvints / vat-calculator

Handle all the hard stuff related to EU MOSS tax/vat regulations, the way it should be.
MIT License
1.2k stars 88 forks source link

Only extend the base validator without creating new custom instance #21

Closed lsimeonov closed 8 years ago

lsimeonov commented 8 years ago

Before that if you try to extend the validation class in your app you can't because you are already using custom instance for the validator.

As you don't override any existing validation properties you can just extend the validator as per laravel documentation

mpociot commented 8 years ago

Thanks for the PR.

I will look into the test part of this PR and merge it afterwards.

mpociot commented 8 years ago

Finally found the time to look through your code. I refactored the Validator tests and merged your changes! Thank you