search

driesvints / vat-calculator

Handle all the hard stuff related to EU MOSS tax/vat regulations, the way it should be.
MIT License
1.2k stars 88 forks source link

Resolve config repository with type-hint on the constructor #58

Closed dnmarques closed 6 years ago

dnmarques commented 6 years ago

When using this package inside Laravel 5.4, command php artisan route:list is broke because config repository is not correctly being resolved.

Instead, the repository can be type hinted in the constructor.

codecov-io commented 6 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #58   +/-   ##
======================================
  Coverage    93.8%   93.8%           
======================================
  Files           5       5           
  Lines         210     210           
======================================
  Hits          197     197           
  Misses         13      13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f76ccd...c198dbd. Read the comment docs.

mpociot commented 6 years ago

Thank you!