VAT validation fails silently

driesvints / vat-calculator

Handle all the hard stuff related to EU MOSS tax/vat regulations, the way it should be.

MIT License

1.2k stars 88 forks source link

VAT validation fails silently #62

Closed mkarnicki closed 5 years ago

mkarnicki commented 6 years ago

I know there are similar issues reported (one closed, one open about SOAP failure), but this one looks different. I'm checking a valid German VAT ID. I confirmed with VIES site by entering this random but valid German VAT ID 160475096 that their service is currently down.

The call to:

(new VatCalculator)->isValidVATNumber($value)

returns false instead of throwing an Exception.

spaze commented 5 years ago

Just hit the same issue and have done a bit research and I believe this was fixed in #52 released as 2.3.0

mkarnicki commented 5 years ago

@spaze Good find. Yes, by looking at the diff it should fix this issue. I like that fix. Thank you for pointing this out. Closing this issue.