search

drift-labs / protocol-v2

On-chain perpetuals dex with multiple liquidity mechanisms
Apache License 2.0
220 stars 116 forks source link

Change Management Policies Needed #1019

Open rsmets opened 7 months ago

rsmets commented 7 months ago

I'm noticing PRs being open and closed with no reviews. Also, the PRs' description content itself is often very sparse or non-existent.

As I noted in a random PR I was looking at:

Wow, I love Drift because I think the engineer work behind it is top notch but I didn't realize that you all allow for PRs to be merged with no review. 😨

I would recommend using gitStream to allow for automated approvals based on conditions (e.g., labels, change content).

I also recommend creating a default PR template that forces authors to provide more contextual information in each PR. You can do that at the Org level, so it applies to all repos' PRs. Here are the github docs on this. It's pretty standard stuff for OS communities.

Please note this recommendations are coming from experience! I'm just looking out for my favorite decentralized perp market. I love what you guys are building - I'm an avid user.

crispheaney commented 7 months ago

thanks for the feedback! we can do a better job here, will take a look at these tools

for the pr you shared, a contributor review it and gave approval in another chat, which isn't great for people following along