drift-org / backend

2 stars 0 forks source link

Feat/#6 #7

Closed teekenzie closed 3 years ago

teekenzie commented 3 years ago

Contributors

@teekenzie

Reviewers

@brandonLi8 @aidenszeto

Relevant issue

Closes #6

Summary of change

Testing

brandonLi8 commented 3 years ago

Looks solid. Here's some other fields we could discuss and consider adding: PastDrifts - array of drift object IDs that the User has participated in Friends - array of user object IDs that the User is friends with Username - string indicating User's unique username; it might be preferable for users to be identified by username rather than email FriendRequests - array of user object IDs that indicate the User's pending friend requests CurrentDrift - object including status on whether or not the User is currently in a drift, along with the drift's object ID

Agreed. @aidenszeto lets maybe include that for #1? This was meant to be a small ticket so we can start login/sign-up.

aidenszeto commented 3 years ago

Looks solid. Here's some other fields we could discuss and consider adding: PastDrifts - array of drift object IDs that the User has participated in Friends - array of user object IDs that the User is friends with Username - string indicating User's unique username; it might be preferable for users to be identified by username rather than email FriendRequests - array of user object IDs that indicate the User's pending friend requests CurrentDrift - object including status on whether or not the User is currently in a drift, along with the drift's object ID

Agreed. @aidenszeto lets maybe include that for #2? This was meant to be a small ticket so we can start login/sign-up.

Sounds good I'll make a ticket to expand on the User Model. Let's just merge this in so we have a basis for the mgm models too.

aidenszeto commented 3 years ago

@teekenzie Should be good for a merge